Skip to content

fix: multiple results won't crash the parser#55

Merged
weiwei merged 4 commits intomasterfrom
pytest_fix
Nov 27, 2020
Merged

fix: multiple results won't crash the parser#55
weiwei merged 4 commits intomasterfrom
pytest_fix

Conversation

@weiwei
Copy link
Owner

@weiwei weiwei commented Nov 27, 2020

Fix #54

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #55 (029575c) into master (ec77530) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
+ Coverage   99.42%   99.44%   +0.01%     
==========================================
  Files           4        4              
  Lines        1040     1074      +34     
==========================================
+ Hits         1034     1068      +34     
  Misses          6        6              
Impacted Files Coverage Δ
junitparser/__init__.py 100.00% <100.00%> (ø)
junitparser/junitparser.py 99.12% <100.00%> (+0.02%) ⬆️
tests/test_fromfile.py 98.69% <100.00%> (+<0.01%) ⬆️
tests/test_general.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec77530...029575c. Read the comment docs.

@weiwei weiwei merged commit e1270eb into master Nov 27, 2020
@weiwei weiwei deleted the pytest_fix branch November 27, 2020 18:04
carlescufi added a commit to carlescufi/junitparser that referenced this pull request Nov 22, 2022
After weiwei#55 was merged, multiple
results are accepted in a single TestCase instance. However, this test,
which was wrong because it was invoking self.assertRaised() without a
`with` statement, remained in the tree without failing.

Instead now verify that we can import XML with multiple results in a
single TestCase instance.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure to parse xUnit2

1 participant