Pe 1b rv

[mcoduoza]

Corresponding AHA CI is here: StanfordAHA/aha#2023

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

sam/onyx/hw_nodes/compute_node.py:238

• [nitpick] The returned tuple now includes additional configuration values. Consider adding an inline comment or updating the method documentation to clarify the order and correspondence of these values with the configuration dictionary.

return (op_code, bypass_rv, pe_only, pe_in_external, active_inputs, 0, 1, 0), cfg_kwargs

sam/onyx/hw_nodes/compute_node.py:236

• [nitpick] The inline comment for 'active_1b_output' is nearly identical to that for 'active_16b_output' and may cause confusion. Consider rewording the comment to clearly distinguish the intended behavior for the 1b output.

'active_1b_output': 0  # sparse apps can only use the 16b output of the ALU and cannot use the 1b output

[mbstrange2]

Could you make the 0, 1, 0 be variables instead that are hardcoded to match the style of the rest of this? Will make future changes more seamless if needed.

[mcoduoza]

Could you make the 0, 1, 0 be variables instead that are hardcoded to match the style of the rest of this? Will make future changes more seamless if needed.

Sure! done

[mbstrange2]

LGTM