Skip to content
Merged

d #309

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-image-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ jobs:
uses: dorny/paths-filter@v2.10.2
id: go-changes
with:
base: ${{ github.event.pull_request_target.base.sha }}
ref: ${{ github.event.pull_request_target.head.sha }}
base: ${{ github.event.pull_request.base.sha }}
ref: ${{ github.event.pull_request.head.sha }}
filters: |
src:
- api/**
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/debug-context.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,11 @@ jobs:
# "github.head_ref = pr/welan/md-spell"
echo "github.head_ref = ${{ github.head_ref }}"

# pull_request or pull_request_target 都能获取到
echo "github.event.pull_request.base.sha = ${{ github.event.pull_request.base.sha }}"
echo "github.event.pull_request.head.sha = ${{ github.event.pull_request.head.sha }}"

# 这个获取不到任何东西 ,即使 pull_request_target 也获取不到
echo "github.event.pull_request_target.base.sha = ${{ github.event.pull_request_target.base.sha }}"
echo "github.event.pull_request_target.head.sha = ${{ github.event.pull_request_target.head.sha }}"

Expand Down Expand Up @@ -75,3 +77,10 @@ jobs:
# ================ for workflow_call, only available in a reusable workflow
echo "inputs = ${{ inputs }}"
echo "inputs = ${{ inputs.mytag }}"

# ========= env
echo "GITHUB_BASE_REF = ${{ GITHUB_BASE_REF }}"
echo "GITHUB_HEAD_REF = ${{ GITHUB_HEAD_REF }}"
echo "GITHUB_REF = ${{ GITHUB_REF }}"
echo "GITHUB_REF_NAME = ${{ GITHUB_REF_NAME }}"
echo "GITHUB_SHA = ${{ GITHUB_SHA }}"
10 changes: 10 additions & 0 deletions .github/workflows/debug-context2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,11 @@ jobs:
# "github.head_ref = pr/welan/md-spell"
echo "github.head_ref = ${{ github.head_ref }}"

# pull_request or pull_request_target 都能获取到
echo "github.event.pull_request.base.sha = ${{ github.event.pull_request.base.sha }}"
echo "github.event.pull_request.head.sha = ${{ github.event.pull_request.head.sha }}"

# 这个获取不到任何东西 ,即使 pull_request_target 也获取不到
echo "github.event.pull_request_target.base.sha = ${{ github.event.pull_request_target.base.sha }}"
echo "github.event.pull_request_target.head.sha = ${{ github.event.pull_request_target.head.sha }}"

Expand Down Expand Up @@ -73,3 +75,11 @@ jobs:
# ================ for workflow_call, only available in a reusable workflow
echo "inputs = ${{ inputs }}"
echo "inputs = ${{ inputs.mytag }}"

# ========= env
echo "GITHUB_BASE_REF = ${{ GITHUB_BASE_REF }}"
echo "GITHUB_HEAD_REF = ${{ GITHUB_HEAD_REF }}"
echo "GITHUB_REF = ${{ GITHUB_REF }}"
echo "GITHUB_REF_NAME = ${{ GITHUB_REF_NAME }}"
echo "GITHUB_SHA = ${{ GITHUB_SHA }}"

2 changes: 1 addition & 1 deletion docs/contributing/development/chart.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ the '/' of branch 'github_pages' is used as github page
each version of chart package will be automatically created by CI,
they will be pushed to '/chart' of branch 'github_pages'.

the '/index.yaml' of branch 'github_pages' will also be updated by CI.
the '/index.yaml' of branch 'github_pages' will also be updated by CI.

so, you could use following command to get the chart

Expand Down
2 changes: 1 addition & 1 deletion pkg/lock/lock.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ type RWMutex struct {

// Mutex is equivalent to sync.Mutex but applies deadlock detection if the
// built tag "lockdebug" is set
type Mutex struct {
type Mutex struct {
internalMutex
}