fix: disable continuous_batching and harden smoke tests#25
Open
fix: disable continuous_batching and harden smoke tests#25
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picked from the now-closed #23 (stale branch). Contains the only useful changes that weren't already on main.
continuous_batchingvllm flag instack_init.pyandonboarding.pywithTODO(#17)— workaround forwaybarrios/vllm-mlx#211(missing return inload_model_with_fallback)ServiceManager.start_vllm()— absorbs model weight loading / JIT compilation latency so test inference timeouts measure actual generationtime.sleep(1)+ orphan process cleanup inServiceManager.stop_all()to reduce port-still-bound flakinesskill_processes_on_port()to avoid killing pytest itselfopenai>=2.30.0to dev dependencies (needed for harness tests)Test plan
make lint— all checks passedmake test— 1480 passed, 89% coveragemake test-catalog— 121 passed🤖 Generated with Claude Code