fix: add explicit permissions to CI and integration workflows#34
Merged
fix: add explicit permissions to CI and integration workflows#34
Conversation
The interactive `mlx-stack setup` command walks through hardware detection, model selection, downloading, and stack startup in one guided flow — but it was completely missing from the README. Now it leads the Quick Start and CLI Reference sections, with the manual step-by-step flow in a collapsible details block. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Resolves all 4 CodeQL code-scanning alerts for missing workflow permissions by adding `permissions: contents: read` to ci.yml, integration-nightly.yml, and integration-prerelease.yml. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
test_follow_handles_empty_file_after_truncation used fixed sleep(1.0) to wait for the follow thread to observe truncated content, causing intermittent CI failures. Replaced with wait_for_content() polling pattern already used by the adjacent test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
weklund
pushed a commit
that referenced
this pull request
Apr 4, 2026
🤖 I have created a release *beep* *boop* --- ## [0.3.6](v0.3.5...v0.3.6) (2026-04-04) ### Bug Fixes * add explicit permissions to CI and integration workflows ([#34](#34)) ([0f8bfb0](0f8bfb0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions: contents: readtoci.yml,integration-nightly.yml, andintegration-prerelease.ymlrelease-please.ymlandpublish.ymlalready had explicit permissionsTest plan
contents: readis sufficient)🤖 Generated with Claude Code