Skip to content

Update quaternary.R#2

Merged
mvfki merged 1 commit intowelch-lab:mainfrom
ttriche:patch-1
Apr 22, 2025
Merged

Update quaternary.R#2
mvfki merged 1 commit intowelch-lab:mainfrom
ttriche:patch-1

Conversation

@ttriche
Copy link
Copy Markdown
Contributor

@ttriche ttriche commented Apr 17, 2025

fixes #3 (typo that prevented interactive output from working)

fix typo that prevented interactive output from working
@ttriche
Copy link
Copy Markdown
Contributor Author

ttriche commented Apr 22, 2025

nb. I found recently that plotTernary() does not automatically generate the delightful sample-ID labels which plotQuaternary(..., interactive=TRUE) does.

May attempt to patch that, too. Super handy package.

@mvfki mvfki merged commit decd8ab into welch-lab:main Apr 22, 2025
3 checks passed
@mvfki
Copy link
Copy Markdown
Collaborator

mvfki commented Apr 22, 2025

Thank you so much, Tim. I'll also make sure to add the unit test that covers this part after merging.

@mvfki
Copy link
Copy Markdown
Collaborator

mvfki commented Apr 22, 2025

Just to note that, there would be another error here when interactive = TRUE is explicitly specified in a user call. We should actually, simply, remove this argument from there. Thank you again for touching this part of code.

A new commit is also pushed regarding the fix (dea6e70). Now I'm wrapping things up for a new release on CRAN, which might take a few days for CRAN team to fix their check system.

@mvfki
Copy link
Copy Markdown
Collaborator

mvfki commented Apr 23, 2025

Hi @ttriche

CRAN accepted just now. BTW, I also had the patch for showing sample-ID in a ternary plot.

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plotQuaternary.default(..., interactive=TRUE) fails

2 participants