Skip to content

WELD-2827 Fire Startup/Shutdown event within a synchronized block #3273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manovotn merged 1 commit into from
Jan 14, 2026
+9 −9
Merged

WELD-2827 Fire Startup/Shutdown event within a synchronized block #3273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions modules/web/src/main/java/org/jboss/weld/module/web/servlet/HttpContextLifecycle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,36 +149,36 @@ public HttpRequestContext getRequestContext() {

public void contextInitialized(ServletContext ctx) {
servletContextService.contextInitialized(ctx);
fireEventForApplicationScope(ctx, Initialized.Literal.APPLICATION);
fireSynchronizedEvent(ctx, ServletContext.class, Initialized.Literal.APPLICATION);
Environment env = Container.getEnvironment();
if (module != null && env != null && env.automaticallyHandleStartupShutdownEvents()) {
module.fireEvent(Startup.class, new Startup(), Any.Literal.INSTANCE);
fireSynchronizedEvent(new Startup(), Startup.class, Any.Literal.INSTANCE);
}
}

public void contextDestroyed(ServletContext ctx) {
// firstly, fire Shutdown event
Environment env = Container.getEnvironment();
if (module != null && env != null && env.automaticallyHandleStartupShutdownEvents()) {
module.fireEvent(Shutdown.class, new Shutdown(), Any.Literal.INSTANCE);
fireSynchronizedEvent(new Shutdown(), Shutdown.class, Any.Literal.INSTANCE);
}
// TODO WELD-2282 Firing these two right after each other does not really make sense
fireEventForApplicationScope(ctx, BeforeDestroyed.Literal.APPLICATION);
fireEventForApplicationScope(ctx, Destroyed.Literal.APPLICATION);
fireSynchronizedEvent(ctx, ServletContext.class, BeforeDestroyed.Literal.APPLICATION);
fireSynchronizedEvent(ctx, ServletContext.class, Destroyed.Literal.APPLICATION);
}

private void fireEventForApplicationScope(ServletContext ctx, Annotation qualifier) {
private void fireSynchronizedEvent(Object payload, Class<?> payloadClass, Annotation qualifier) {
if (module != null) {
// Deliver events sequentially
synchronized (container) {
if (module.isWebModule()) {
module.fireEvent(ServletContext.class, ctx, qualifier);
module.fireEvent(payloadClass, payload, qualifier);
} else {
// fallback for backward compatibility
ServletLogger.LOG.noEeModuleDescriptor(beanManager);
final EventMetadata metadata = new EventMetadataImpl(ServletContext.class, null,
final EventMetadata metadata = new EventMetadataImpl(payloadClass, null,
Collections.singleton(qualifier));
beanManager.getAccessibleLenientObserverNotifier().fireEvent(ServletContext.class, ctx, metadata,
beanManager.getAccessibleLenientObserverNotifier().fireEvent(payloadClass, payload, metadata,
qualifier);
}
}
Expand Down
Loading