Skip to content

[7.9] Add test for running composer with --no-system-repos option #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bcl merged 1 commit into from
Apr 27, 2020
Merged

[7.9] Add test for running composer with --no-system-repos option #930

bcl merged 1 commit into from
Apr 27, 2020

Conversation

@atodorov
Copy link
Member

@atodorov atodorov commented Dec 19, 2019

  • add test coverage for rhbz#1650363
  • cherry-picked from 5322664

Related: rhbz#1785159

@atodorov atodorov requested a review from bcl December 19, 2019 10:02
@coveralls
Copy link

coveralls commented Dec 19, 2019

Pull Request Test Coverage Report for Build 2475

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%
Totals Coverage Status
Change from base Build 2468: 0.0%
Covered Lines:
Relevant Lines: 0
💛 - Coveralls

@atodorov
Copy link
Member Author

atodorov commented Dec 19, 2019

@bcl PR #526 which added this functionality has been labeled as rhel7-extras but I don't think it made it to this branch. Can you give more info on what happened/was intended to happen?

@bcl
Copy link
Contributor

bcl commented Dec 19, 2019

@bcl PR #526 which added this functionality has been labeled as rhel7-extras but I don't think it made it to this branch. Can you give more info on what happened/was intended to happen?

I think I meant to make a bug to cover backporting it, but never did. Guess I'll do that now.

@atodorov atodorov changed the title Add test for running composer with --no-system-repos option [do not merge yet][7.x] Add test for running composer with --no-system-repos option Jan 8, 2020
@atodorov atodorov changed the title [do not merge yet][7.x] Add test for running composer with --no-system-repos option [do not merge yet][7.9] Add test for running composer with --no-system-repos option Jan 8, 2020
@atodorov
Copy link
Member Author

atodorov commented Apr 16, 2020

@bcl PR #526 which added this functionality has been labeled as rhel7-extras but I don't think it made it to this branch. Can you give more info on what happened/was intended to happen?

I think I meant to make a bug to cover backporting it, but never did. Guess I'll do that now.

https://bugzilla.redhat.com/show_bug.cgi?id=1785388

@atodorov atodorov force-pushed the rhel7_nosystemrepos branch from a4f40c7 to cc6d8bf Compare April 20, 2020 10:21
@atodorov atodorov mentioned this pull request Apr 20, 2020
Merged
@jikortus @atodorov
Add test for running composer with --no-system-repos option
080d076 
- add test coverage for rhbz#1650363
- cherry-picked from 5322664

Related: rhbz#1785159
@atodorov atodorov force-pushed the rhel7_nosystemrepos branch from cc6d8bf to 080d076 Compare April 21, 2020 10:56
@atodorov atodorov changed the title [do not merge yet][7.9] Add test for running composer with --no-system-repos option [7.9] Add test for running composer with --no-system-repos option Apr 27, 2020
@atodorov
Copy link
Member Author

atodorov commented Apr 27, 2020

I've tested this today manually with lorax-composer-19.7.40-1.el7_9.x86_64 and it passes. CI job for 7.9 will likely pass after an image refresh.

@bcl feel free to merge if you want.

bcl
bcl approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@bcl bcl merged commit 3e985d6 into weldr:rhel7-extras Apr 27, 2020
@atodorov atodorov deleted the rhel7_nosystemrepos branch April 28, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bcl bcl bcl approved these changes

Assignees

No one assigned

Labels

rhel7-extras

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atodorov @coveralls @bcl @jikortus