Expand Terms as they the user expands them #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The defaultDepth to which we expand Ids is low because otherwise the performance cost is too great and perceivably slow. However, the user has to iteractively expand the branches of the representation tree of variables as they want to view them. We can leverage this interactivity to overcome the limited depth to which we expand. Simply: when the user expands a variable, always expand its corresponding Term a little bit more. Fixes #97
alt-romes
force-pushed
the
wip/romes/T97
branch
from
b6af166 to
18a44b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The defaultDepth to which we expand Ids is low because otherwise the performance cost is too great and perceivably slow.
However, the user has to iteractively expand the branches of the representation tree of variables as they want to view them.
We can leverage this interactivity to overcome the limited depth to which we expand. Simply: when the user expands a variable, always expand its corresponding Term a little bit more.
Fixes #97