Skip to content

Conversation

@ivyleavedtoadflax
Copy link
Contributor

@ivyleavedtoadflax ivyleavedtoadflax commented Mar 18, 2020

This is a general tidy up:

  • moves prodigy functions to deep_reference_parser.prodigy module
  • moves io functions to the deep_reference_parser.io module
  • linting with black

There are no substantive changes to the codebase, so if they tests pass, this should be good to go.

@ivyleavedtoadflax ivyleavedtoadflax changed the base branch from master to feature/ivyleavedtoadflax/refactor_load_tsv March 18, 2020 02:02
@ivyleavedtoadflax ivyleavedtoadflax changed the base branch from feature/ivyleavedtoadflax/refactor_load_tsv to master March 18, 2020 02:07
@ivyleavedtoadflax ivyleavedtoadflax self-assigned this Mar 18, 2020
@codecov-io
Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #19 into master will increase coverage by 3.24%.
The diff coverage is 92.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   81.31%   84.56%   +3.24%     
==========================================
  Files          14       16       +2     
  Lines        1247     1192      -55     
==========================================
- Hits         1014     1008       -6     
+ Misses        233      184      -49
Impacted Files Coverage Δ
deep_reference_parser/reference_utils.py 100% <ø> (+35.94%) ⬆️
deep_reference_parser/deep_reference_parser.py 87.87% <100%> (-0.05%) ⬇️
deep_reference_parser/prodigy/labels_to_prodigy.py 100% <100%> (ø)
deep_reference_parser/prodigy/prodigy_to_tsv.py 97.47% <100%> (ø) ⬆️
deep_reference_parser/prodigy/misc.py 68.75% <68.75%> (ø)
deep_reference_parser/io/io.py 96.87% <97.82%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085f0fb...2e7da2e. Read the comment docs.

@nsorros
Copy link

nsorros commented Mar 18, 2020

On a separate note from this PR, make test should depend on virtualenv/.installed

@ivyleavedtoadflax ivyleavedtoadflax merged commit ae2fcf2 into master Mar 18, 2020
@ivyleavedtoadflax ivyleavedtoadflax deleted the reorganise branch March 18, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants