-
Notifications
You must be signed in to change notification settings - Fork 1
Reorganise sub-module structure #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also removes defunct load_data
b88f431 to
519937f
Compare
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 81.31% 84.56% +3.24%
==========================================
Files 14 16 +2
Lines 1247 1192 -55
==========================================
- Hits 1014 1008 -6
+ Misses 233 184 -49
Continue to review full report at Codecov.
|
|
On a separate note from this PR, |
nsorros
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a general tidy up:
deep_reference_parser.prodigymoduledeep_reference_parser.iomoduleThere are no substantive changes to the codebase, so if they tests pass, this should be good to go.