Conversation
- Add skip-to-main-content link for keyboard users (WCAG 2.4.1) - Wrap body in semantic <header> skip-nav + <main id=main-content> landmark - Add aria-label to decorative background divs (role=presentation) - Confirm lang=en on <html> (WCAG 3.1.1) - Add viewport meta description for screen readers - These fixes are the first real content to satisfy the axe-core CI gate added in feat(accessibility): 767afd7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
๐ง What This PR Does
Second wave of accessibility fixes โ targets
page.tsx, the main dashboard UI.Builds on the landmark/skip-nav foundation from PR #32.
๐ Changes โ
agents/dashboard/app/page.tsxrole="tablist",role="tab",aria-selected,aria-controlsrole="tabpanel",aria-labelledby,tabIndex={0}role="list"/role="listitem"role="progressbar"+aria-valuenow/min/max<label className="sr-only">+id="command-input"aria-hidden="true"on all visual-only icons/dotsrole="dialog",aria-modal="true",aria-labelledbyhtmlFor/idwiring for email + password๐งช How to Verify
๐ฏ Expected CI Gate Result
All CRITICAL and HIGH axe violations from
page.tsxresolved.Gate: PASS โ
๐ฎ What's Next (PR #3)
aria-liveregions for real-time agent status updates