Skip to content

fix(itn): 7/-12 -> -7/12 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pengzhendong merged 1 commit into from
Dec 24, 2022
Merged

fix(itn): 7/-12 -> -7/12 #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions itn/chinese/rules/fraction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
from itn.chinese.rules.cardinal import Cardinal
from tn.processor import Processor

from pynini.lib.pynutil import delete, insert
from pynini import string_file
from pynini.lib.pynutil import delete, insert, add_weight


class Fraction(Processor):
Expand All @@ -27,14 +28,21 @@ def __init__(self):

def build_tagger(self):
number = Cardinal().number

tagger = (insert('denominator: "') + number +
sign = string_file('itn/chinese/data/number/sign.tsv') # + -

# NOTE(xcsong): default weight = 1.0, set to -1.0 means higher priority
# For example,
# 1.0, 负二分之三 -> { sign: "" denominator: "-2" numerator: "3" }
# -1.0,负二分之三 -> { sign: "-" denominator: "2" numerator: "3" }
tagger = (insert('sign: "') + add_weight(sign, -1.0).ques +
insert('" denominator: "') + number +
delete('分之') + insert('" numerator: "') +
number + insert('"'))
self.tagger = self.add_tokens(tagger)

def build_verbalizer(self):
numerator = delete('numerator: "') + self.SIGMA + delete('"')
sign = delete('sign: "') + self.SIGMA + delete('"')
numerator = delete(' numerator: "') + self.SIGMA + delete('"')
denominator = delete(' denominator: "') + self.SIGMA + delete('"')
verbalizer = numerator + insert('/') + denominator
verbalizer = sign + numerator + insert('/') + denominator
self.verbalizer = self.delete_tokens(verbalizer)
2 changes: 1 addition & 1 deletion runtime/processor/token_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const std::unordered_map<std::string, std::vector<std::string>> TN_ORDERS = {
{"time", {"noon", "hour", "minute", "second"}}};
const std::unordered_map<std::string, std::vector<std::string>> ITN_ORDERS = {
{"date", {"year", "month", "day"}},
{"fraction", {"numerator", "denominator"}},
{"fraction", {"sign", "numerator", "denominator"}},
{"measure", {"numerator", "denominator", "value"}},
{"money", {"currency", "value"}},
{"time", {"hour", "minute", "second", "noon"}}};
Expand Down
2 changes: 1 addition & 1 deletion tn/token_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
'time': ['noon', 'hour', 'minute', 'second']}
ITN_ORDERS = {
'date': ['year', 'month', 'day'],
'fraction': ['numerator', 'denominator'],
'fraction': ['sign', 'numerator', 'denominator'],
'measure': ['numerator', 'denominator', 'value'],
'money': ['currency', 'value'],
'time': ['hour', 'minute', 'second', 'noon']}
Expand Down