feat: support authenticated secret values - #706
Merged
Conversation
Update common-go so nelm v2 reads and writes the versioned AES-GCM secret formats. Signed-off-by: Aleksei Igrychev <aleksei.igrychev@palark.com>
Member
Author
Verification
Review focus
Follow-up
|
alexey-igrychev
marked this pull request as ready for review
August 31, 2026 16:57
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nelm v2 now uses common-go branch
1, adding authenticated AES-GCM secret encryption while retaining read support for existing AES-CBC secrets. It can read and write the format required by the werf v3 rollout.Related: #677
What
Breaking
Secret values
Why
The previous common-go AES-CBC format accepted tampered data and wrong keys without reliable detection, while secret YAML encryption discarded scalar metadata. Nelm needs the common-go v1 implementation so its v2 release participates in the coordinated authenticated-secret rollout with werf v3.