feat: add DockerConfig flag#605
Merged
Merged
Conversation
Signed-off-by: Dmitry Mordvinov <dmitry.mordvinov@flant.com>
Signed-off-by: Dmitry Mordvinov <dmitry.mordvinov@flant.com>
| } | ||
|
|
||
| if err := cli.AddFlag(cmd, &cfg.RegistryCredentialsPath, "oci-chart-repos-creds", common.DefaultRegistryCredentialsPath, "Credentials to access OCI chart repositories", cli.AddFlagOptions{ | ||
| if err := cli.AddFlag(cmd, &cfg.DockerConfig, "docker-config", "", "Docker config directory path. If not specified, uses $DOCKER_CONFIG or ~/.docker (in the order of priority)", cli.AddFlagOptions{ |
Member
There was a problem hiding this comment.
not like that. Grep for KUBECONFIG
Signed-off-by: Dmitry Mordvinov <dmitry.mordvinov@flant.com>
Signed-off-by: Dmitry Mordvinov <dmitry.mordvinov@flant.com>
ilya-lesikov
reviewed
May 6, 2026
| @@ -285,10 +285,6 @@ func ContextWithHelmOptions(ctx context.Context, opts HelmOptions) context.Conte | |||
| } | |||
|
|
|||
| func DefaultDockerConfig() string { | |||
Member
There was a problem hiding this comment.
Default should be set in cli.AddFlag natively, look at how it's done in other flags
Signed-off-by: Dmitry Mordvinov <dmitry.mordvinov@flant.com>
Signed-off-by: Dmitry Mordvinov <dmitry.mordvinov@flant.com>
ilya-lesikov
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.