feat: fail on invalid annotations or labels#614
Merged
Conversation
Signed-off-by: Ilya Drey <ilya.drey@flant.com>
drey
force-pushed
the
feat/drop-invalid-annotations
branch
from
30bec30 to
4525d31
Compare
Signed-off-by: Ilya Drey <ilya.drey@flant.com> Signed-off-by: Ilya Drey <ilya.drey@flant.com>
drey
force-pushed
the
feat/drop-invalid-annotations
branch
from
ae34a06 to
353303a
Compare
Signed-off-by: Ilya Drey <ilya.drey@flant.com>
ilya-lesikov
approved these changes
May 13, 2026
| return NewResourceSpec(obj.(*unstructured.Unstructured), releaseNamespace, opts), nil | ||
| unstruct := obj.(*unstructured.Unstructured) | ||
|
|
||
| if !opts.DropInvalidAnnotationsAndLabels { |
Member
There was a problem hiding this comment.
nitpick: if opts.DropInvalidAnnotationsAndLabels would be easier to understand, otherwise the else clause is effectively a double negation
| func stripInvalidEntries(filePath string, obj map[string]interface{}, fields ...string) map[string]string { | ||
| result := make(map[string]string) | ||
|
|
||
| ctx := logboek.NewContext(context.Background(), logboek.DefaultLogger()) |
Member
There was a problem hiding this comment.
just pass ctx everywhere, it's fine, we'll need it sooner or later anyways
Signed-off-by: Ilya Drey <ilya.drey@flant.com>
Signed-off-by: Ilya Drey <ilya.drey@flant.com>
drey
force-pushed
the
feat/drop-invalid-annotations
branch
from
c13fd59 to
61ac280
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.