Fix for browser support check#37
Merged
wesbos merged 2 commits intowesbos:masterfrom Oct 2, 2020
jaceksupernak:master
Merged
Conversation
Fixes the issue of returning true all the time regardless of window.SpeechRecognition value.
a = {}
'b' in a; //false
a.b = undefined;
'b' in a; //true
Update speech-FINISHED.js
Owner
|
thanks! |
vasconsaurus
pushed a commit
to vasconsaurus/beginner-javascript
that referenced
this pull request
Jul 7, 2022
Fix for browser support check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of checking if the variable exists in window, we should check the value of the variable instead. The variable will always exist in window because it has been defined beforehand.
