Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the "Alliance Before the Sacred Seal" event, adding comprehensive map configurations, campaign logic, and localization support across multiple languages. Feedback from the review identifies missing or misplaced generated configuration markers in the map files and inconsistent method usage for clearing bosses. Additionally, a translation correction is needed for the Traditional Chinese localization file to ensure consistency.
| MAP_SIREN_HAS_BOSS_ICON_SMALL = True | ||
| MAP_SWIPE_MULTIPLY = (1.179, 1.201) | ||
| MAP_SWIPE_MULTIPLY_MINITOUCH = (1.140, 1.161) | ||
| MAP_SWIPE_MULTIPLY_MAATOUCH = (1.107, 1.127) |
There was a problem hiding this comment.
The Config class is missing the # ===== End of generated config ===== marker. This marker is essential for the configuration generator to correctly identify and update the generated block in the future.
| MAP_SWIPE_MULTIPLY_MAATOUCH = (1.107, 1.127) | |
| MAP_SWIPE_MULTIPLY_MAATOUCH = (1.107, 1.127) | |
| # ===== End of generated config ===== |
| return self.battle_default() | ||
|
|
||
| def battle_5(self): | ||
| return self.fleet_boss.clear_boss() |
There was a problem hiding this comment.
Inconsistent use of self.fleet_boss.clear_boss(). Other files in this event (e.g., a1.py, a2.py) use the standard self.clear_boss() method provided by CampaignBase. It is recommended to use the standard method for consistency across all map files.
| return self.fleet_boss.clear_boss() | |
| return self.clear_boss() |
| # ===== End of generated config ===== | ||
|
|
||
| MAP_CHAPTER_SWITCH_20241219 = True | ||
| STAGE_ENTRANCE = ['half', '20240725'] | ||
| MAP_HAS_MODE_SWITCH = True | ||
| STAGE_INCREASE_AB = True | ||
| MAP_WALK_USE_CURRENT_FLEET = True | ||
| MAP_SIREN_HAS_BOSS_ICON_SMALL = True | ||
| MAP_SWIPE_MULTIPLY = (1.179, 1.201) | ||
| MAP_SWIPE_MULTIPLY_MINITOUCH = (1.140, 1.161) | ||
| MAP_SWIPE_MULTIPLY_MAATOUCH = (1.107, 1.127) |
There was a problem hiding this comment.
The # ===== End of generated config ===== marker is misplaced. Several configuration items (lines 60-68) that are typically part of the generated block are currently outside of it. This may cause issues with the configuration generator.
| # ===== End of generated config ===== | |
| MAP_CHAPTER_SWITCH_20241219 = True | |
| STAGE_ENTRANCE = ['half', '20240725'] | |
| MAP_HAS_MODE_SWITCH = True | |
| STAGE_INCREASE_AB = True | |
| MAP_WALK_USE_CURRENT_FLEET = True | |
| MAP_SIREN_HAS_BOSS_ICON_SMALL = True | |
| MAP_SWIPE_MULTIPLY = (1.179, 1.201) | |
| MAP_SWIPE_MULTIPLY_MINITOUCH = (1.140, 1.161) | |
| MAP_SWIPE_MULTIPLY_MAATOUCH = (1.107, 1.127) | |
| MAP_CHAPTER_SWITCH_20241219 = True | |
| STAGE_ENTRANCE = ['half', '20240725'] | |
| MAP_HAS_MODE_SWITCH = True | |
| STAGE_INCREASE_AB = True | |
| MAP_WALK_USE_CURRENT_FLEET = True | |
| MAP_SIREN_HAS_BOSS_ICON_SMALL = True | |
| MAP_SWIPE_MULTIPLY = (1.179, 1.201) | |
| MAP_SWIPE_MULTIPLY_MINITOUCH = (1.140, 1.161) | |
| MAP_SWIPE_MULTIPLY_MAATOUCH = (1.107, 1.127) | |
| # ===== End of generated config ===== |
| "event_20260226_cn": "春滿客棧Online", | ||
| "event_20260326_cn": "漫遊者招募計劃", | ||
| "event_20260417_cn": "假日航線閃耀海濱", | ||
| "event_20260520_cn": "Alliance Before the Sacred Seal", |
There was a problem hiding this comment.
The translation for event_20260520_cn is currently in English. It should be translated to Traditional Chinese to maintain consistency with the rest of the file.
| "event_20260520_cn": "Alliance Before the Sacred Seal", | |
| "event_20260520_cn": "聖印前的同盟", |
1 participant
No description provided.