Skip to content

Conversation

@mplucinski
Copy link
Contributor

Due to recent change in source files location (new src directory), tests stopped working. I am aware that tests are currently in rewrite in tests branch, but this commit fixes the mainline until rewritten infrastructure is ready.

@westes
Copy link
Owner

westes commented Jun 20, 2014

This is not going to merge well since you're changing files that are getting deleted. I'm nearly done with the test suite cleanup so I'd like to not merge this in and just finish up the tests branch instead of explaining to git what is going on.

That being said, I'll leave this open for now in case the test suite offers problems that I have not foreseen.

@mplucinski
Copy link
Contributor Author

I've proposed it, because without this change, it is not possible for me to prove that my upcoming changes does not break anything. To be honest, I do not fully understand your point of view - where exactly do you see a problem in later merging? Git should give you clear information about conflict reason; at least git gui tells that "local" file has been deleted, while "remote" has been modified.

@westes
Copy link
Owner

westes commented Jun 21, 2014

I mean that I've rewritten all but 7 of the tests and it's mostly gone smoothly. And convincing git to add this change in is going to add a lot of work to files that are essentially already deleted. I started to rebase this change in and it looked rather more complicated than I can justify the effort for.

@westes
Copy link
Owner

westes commented Jun 24, 2014

YOu can run something like this:

cd flex/tests
make check FLEX=../../src/flex CFLAGS=-I../../src

and get most of the tests to pass as is.

Note that those paths are relative to where the tests are run, whcih is in each of the individual test-* subdirectories.

The tests that fail are the c++ ones which probably need the right make variable set to pass the same -I option.

@westes
Copy link
Owner

westes commented Nov 17, 2014

I've just pushed the test suite layout changes onto master, so there's no longer a need for this. Thanks for your interest and now we get to do the fun stuff on the unicode pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants