fix: reset drag state on pointer leave to prevent stuck transitions#113
Open
q404365631 wants to merge 1 commit intowethegit:mainfrom
Open
fix: reset drag state on pointer leave to prevent stuck transitions#113q404365631 wants to merge 1 commit intowethegit:mainfrom
q404365631 wants to merge 1 commit intowethegit:mainfrom
Conversation
When the draggable prop is enabled and the pointer leaves the gallery area during a drag, the gallery previously remained in an in-between state because isDragging was never reset. This adds an onPointerLeave handler that mirrors the onPointerUp logic: it checks the swipe threshold and transitions to the nearest item, then resets all touch state. Closes wethegit#112
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the draggable prop is set to true and the pointer leaves the gallery area during a drag/swipe, the gallery gets stuck in an in-between state because the drag flags are never reset.
Solution
Add an onPointerLeave handler to GalleryMain that mirrors the onPointerUp logic:
Changes
Closes #112