fix: reject unknown properties on session() and charge() at compile time#203
Merged
brendanjryan merged 2 commits intomainfrom Mar 27, 2026
Merged
fix: reject unknown properties on session() and charge() at compile time#203brendanjryan merged 2 commits intomainfrom
brendanjryan merged 2 commits intomainfrom
Conversation
commit: |
brendanjryan
force-pushed
the
fix/no-extra-keys
branch
2 times, most recently
from
ba24a01 to
cb52419
Compare
brendanjryan
commented
Mar 19, 2026
brendanjryan
force-pushed
the
fix/no-extra-keys
branch
from
cb52419 to
cd2bbbb
Compare
Collaborator
Author
tmm
approved these changes
Mar 27, 2026
| 'mppx': patch | ||
| --- | ||
|
|
||
| Added `NoExtraKeys` compile-time guard to `tempo.session()` and `tempo.charge()`. Unknown properties (e.g. `stream` instead of `sse`) now cause a type error instead of being silently accepted. |
Member
There was a problem hiding this comment.
Suggested change
| Added `NoExtraKeys` compile-time guard to `tempo.session()` and `tempo.charge()`. Unknown properties (e.g. `stream` instead of `sse`) now cause a type error instead of being silently accepted. | |
| Added compile-time guard to `tempo.session()` and `tempo.charge()`. Unknown properties (e.g. `stream` instead of `sse`) now cause a type error instead of being silently accepted. |
src/tempo/server/Session.ts
Outdated
Comment on lines
85
to
93
| export function session<const parameters extends session.Parameters>( | ||
| p?: NoExtraKeys<parameters, session.Parameters>, | ||
| ): Method.Server< | ||
| typeof Methods.session, | ||
| session.DeriveDefaults<parameters>, | ||
| parameters['sse'] extends false | undefined ? undefined : Transport.Sse | ||
| > | ||
| /** @internal */ | ||
| export function session<const parameters extends session.Parameters>(p?: parameters) { |
Member
There was a problem hiding this comment.
instead of the overload, might be worth trying a Union version of NoExtraKeys if you haven't already
Add NoExtraKeys utility type and apply it via overload signatures to
tempo.session() and tempo.charge(). This catches typos like
`stream: { poll: true }` instead of `sse: { poll: true }` that
previously slipped through because generic `extends` constraints
bypass excess property checking.
Fixes the class of bug from PR #159.
brendanjryan
force-pushed
the
fix/no-extra-keys
branch
from
1983c9c to
27dee9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Makes interface for kwargs on mppx core types safer
Solution
Add a
NoExtraKeys<T, Shape>utility type that maps any key inTnot present inShapetonever, and apply it tosession()andcharge()via overload signatures.