feat(TxEnvelopeTempo): derive sender from signature in feePayer serialize#166
Merged
feat(TxEnvelopeTempo): derive sender from signature in feePayer serialize#166
Conversation
…lize Amp-Thread-ID: https://ampcode.com/threads/T-019c3f8a-d6a8-713f-913d-36d5cf2e0268 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When serializing with
format: 'feePayer'and a signature is present, the sender address is now automatically derived from the signature — removing the need for an explicitsenderoption.ecrecoverfrom the sign payloaduserAddresson the signaturesenderis now optional in the feePayer format options (still accepted for explicit override).This eliminates the need for the
from+0xfeefeefeefeemarker hack on the viem side.