Skip to content

fix: support transaction block timestamps#248

Merged
jxom merged 1 commit into
mainfrom
fix/tempo-block-timestamp-snapshot
May 14, 2026
Merged

fix: support transaction block timestamps#248
jxom merged 1 commit into
mainfrom
fix/tempo-block-timestamp-snapshot

Conversation

@jxom
Copy link
Copy Markdown
Member

@jxom jxom commented May 14, 2026

Summary

  • add optional blockTimestamp support to transaction RPC/model conversion
  • assert Tempo latest e2e transaction responses include blockTimestamp without snapshotting the dynamic timestamp value
  • cover blockTimestamp in Tempo transaction fromRpc/toRpc unit snapshots

Fixes failing job: https://github.com/wevm/ox/actions/runs/25853578978/job/75965770232

Verification

  • pnpm exec biome check src/core/Transaction.ts src/tempo/Transaction.test.ts src/tempo/e2e.test.ts
  • pnpm check:types
  • pnpm test --project core src/core/_test/Transaction.test.ts --bail=1
  • pnpm test --project tempo-unit src/tempo/Transaction.test.ts --bail=1
  • VITE_TEMPO_TAG=latest pnpm test --project tempo-unit --project tempo --bail=1 --coverage

@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ox Ready Ready Preview, Comment May 14, 2026 8:13pm

Request Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 14, 2026

Open in StackBlitz

npm i https://pkg.pr.new/ox@248

commit: f87dd87

@jxom jxom force-pushed the fix/tempo-block-timestamp-snapshot branch from b9ebeac to f87dd87 Compare May 14, 2026 20:06
@jxom jxom changed the title test(tempo): ignore block timestamp in e2e snapshots fix: support transaction block timestamps May 14, 2026
@jxom jxom force-pushed the fix/tempo-block-timestamp-snapshot branch from f87dd87 to 71fa563 Compare May 14, 2026 20:08
@jxom jxom merged commit e0474e9 into main May 14, 2026
10 of 11 checks passed
@jxom jxom deleted the fix/tempo-block-timestamp-snapshot branch May 14, 2026 20:08
@github-actions github-actions Bot mentioned this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant