fix: support transaction block timestamps#248
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
b9ebeac to
f87dd87
Compare
f87dd87 to
71fa563
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blockTimestampsupport to transaction RPC/model conversionblockTimestampwithout snapshotting the dynamic timestamp valueblockTimestampin Tempo transactionfromRpc/toRpcunit snapshotsFixes failing job: https://github.com/wevm/ox/actions/runs/25853578978/job/75965770232
Verification
pnpm exec biome check src/core/Transaction.ts src/tempo/Transaction.test.ts src/tempo/e2e.test.tspnpm check:typespnpm test --project core src/core/_test/Transaction.test.ts --bail=1pnpm test --project tempo-unit src/tempo/Transaction.test.ts --bail=1VITE_TEMPO_TAG=latest pnpm test --project tempo-unit --project tempo --bail=1 --coverage