fix: prevent duplicate WebSocket subscriptions after reconnect #4162
+181
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When eth_unsubscribe was called while the socket was disconnected, the subscription was never removed from the subscriptions map because the delete only happened in the response callback. On reconnect, the socket would re-subscribe to these 'zombie' subscriptions, causing duplicate callbacks. The fix moves subscriptions.delete() to happen immediately when eth_unsubscribe is called, before attempting to send the request. Closes #3957
🦋 Changeset detectedLatest commit: 1616a29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3957
When using
watchBlockNumber(or other WebSocket subscriptions) and the connection fails and reconnects, callingunwatch()and thenwatch()again would cause duplicate callbacks for the same block numbers.