feat: Add default dataSuffix for transaction actions #4249
Merged
+812
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e806de6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
- Use default param value for dataSuffix with client.dataSuffix fallback - Inline data concatenation instead of separate variable - writeContract passes dataSuffix through to sendTransaction - Add dataSuffix param to sendTransaction/sendTransactionSync types - Simplify sendCalls capabilities logic with imperative style
…ientDataSuffix utility) Amp-Thread-ID: https://ampcode.com/threads/T-019be2de-0430-7178-809d-1116dd29eb13 Co-authored-by: Amp <amp@ampcode.com>
This was referenced Jan 21, 2026
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements proposal defined here to allow apps to set a default data suffix when creating a client. When transactions are placed with this client, it will automatically add the dataSuffix unless one is explicitly passed.
Note:
I initially tried only adding this to wallet clients, but found that:
dataSuffixparam in nonstandard ways in order to use it laterestimateContractGasandsimulateContractare methods onpublicClient, so there was precedent to add this to the base clientI also had to add a
dataSuffixparam tosendTransactionandsendTransactionSync, aswalletClient.writeContractneeds to be able to take adataSuffixand pass it to the underlying action and have that apply rather than the global client'sdataSuffix.