fix(sendCallsSync): use getAction to respect client overrides#4315
Merged
fix(sendCallsSync): use getAction to respect client overrides#4315
Conversation
sendCallsSync was directly calling the imported sendCalls and waitForCallsStatus functions, bypassing any client-level overrides. This broke smart account clients (e.g. permissionless) that override sendCalls to use user operations instead of wallet_sendCalls. Now uses getAction() pattern consistent with writeContracts and other action compositions. Fixes #4307 Amp-Thread-ID: https://ampcode.com/threads/T-019c29f1-a4b7-7048-ba52-d38a84e42bf4 Co-authored-by: Amp <amp@ampcode.com>
🦋 Changeset detectedLatest commit: 6bbb5c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Amp-Thread-ID: https://ampcode.com/threads/T-019c29f1-a4b7-7048-ba52-d38a84e42bf4 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendCallsSyncwas directly calling the importedsendCallsandwaitForCallsStatusfunctions, bypassing any client-level overrides.This broke smart account clients (e.g. permissionless) that override
sendCallsto use user operations instead ofwallet_sendCalls.Fix
Now uses
getAction()pattern consistent withwriteContractsand other action compositions:Fixes #4307