feat: batch matching stateOverrides in call#4337
Merged
Merged
Conversation
|
@haydenshively is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 1271756 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
@jxom is there anything I can do to help get this merged? |
bdf8494 to
69e0d6e
Compare
Contributor
Author
|
bump, how can I help? |
|
+1 would be great for this to be supported |
# Conflicts: # src/actions/public/call.ts
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
client.batch.multicallis enabled,call()skips batching entirely for any call that includes astateOverride. However, the downstream multicall action already supports forwardingstateOverridetoeth_call, so there's no fundamental reason calls sharing the samestateOverridecan't be batched together.This PR removes the blanket
!rpcStateOverrideguard and instead groups batched calls by their serializedstateOverridevalue. Calls with the same override batch together; calls with different overrides (or no override) go to separate batches. ThestateOverrideis then forwarded as the third param in the batchedeth_call.Changes:
!rpcStateOverridecheck that prevented all state-overridden calls from batchingrpcStateOverridethroughscheduleMulticalland include it in the batchedeth_callparamsJSON.stringify(rpcStateOverride)in the batch scheduler ID so calls are grouped by identical overrides