feat: support anonymous events in encodeEventTopics#4554
Closed
tenderdeve wants to merge 1 commit into
Closed
Conversation
Anonymous Solidity events have no signature topic, but encodeEventTopics unconditionally prepended one. Skip the signature hash for events with anonymous: true in the ABI and adjust the return type to reflect the difference. Includes tests for anonymous events with and without args. Fixes wevm#4461
|
@tenderdeve is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encodeEventTopics()unconditionally prepended the event signature hash as the first topic, but anonymous Solidity events (anonymous: true) should have no signature topicabiItem.anonymousand skiptoEventSelector()+ signature prepend for anonymous eventsanonymousboolean — anonymous events return(Hex | Hex[] | null)[], non-anonymous keep[Hex, ...(Hex | Hex[] | null)[]]. Default isfalseso all existing callers are unaffected.getLogs,watchEvent,watchContractEvent,createEventFilter) need no changesFiles:
src/utils/abi/encodeEventTopics.ts— runtime check + return typesrc/utils/abi/encodeEventTopics.test.ts— 4 new test casesFixes #4461
Test plan
[]