fix(abi): handle anonymous events in encodeEventTopics#4582
Closed
tenderdeve wants to merge 1 commit into
Closed
Conversation
Anonymous events do not have a signature topic. Skip prepending the event selector when the abiItem has anonymous: true, and return only the indexed argument topics. Fixes wevm#4461
|
|
@tenderdeve is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
encodeEventTopics unconditionally prepends the event signature as topic[0], which is incorrect for anonymous events. Anonymous events do not emit a signature topic and can use all 4 topic slots for indexed parameters.
This moves the signature computation after the argument encoding and skips it when the event has
anonymous: true.Fixes #4461