Skip to content

fix(chains): correct Sova block explorer default URL#4599

Merged
jxom merged 2 commits into
wevm:mainfrom
esorense:sova-block-explorer-url-typo
May 17, 2026
Merged

fix(chains): correct Sova block explorer default URL#4599
jxom merged 2 commits into
wevm:mainfrom
esorense:sova-block-explorer-url-typo

Conversation

@esorense
Copy link
Copy Markdown
Contributor

What is this PR solving?

This PR fixes a typo in the Sova chain definition:

  • src/chains/definitions/sova.ts
  • blockExplorers.default.url was hhttps://explorer.sova.io
  • corrected to https://explorer.sova.io

This is a real correctness issue (not a design change).
The invalid scheme can break URL parsing and cause explorer-link checks/usages to fail.

Alternatives considered

  • Keep the current value and rely on consumers to handle malformed URLs.
    • Rejected: pushes a bad config downstream.
  • Add runtime normalization/fallback for malformed explorer URLs.
    • Rejected: unnecessary complexity for a single source typo.
  • Apply a minimal source fix in the chain definition.
    • Chosen: smallest, safest, and most maintainable change.

Reviewer attention

Please focus on:

  • The one-line change in src/chains/definitions/sova.ts.
  • Confirming no unrelated chain definitions were modified.

Documentation impact

No documentation changes are required (no API or behavior contract changes beyond correcting bad data).

Tests

No new tests were added because existing coverage already validates explorer URLs in test/scripts/chains.test.ts (blockExplorer.url check).
This change is intended to make Sova pass that existing path with a valid URL scheme.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2026

@esorense is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 12, 2026

🦋 Changeset detected

Latest commit: e04da7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jxom jxom merged commit 2e97454 into wevm:main May 17, 2026
2 of 3 checks passed
@github-actions github-actions Bot mentioned this pull request May 17, 2026
@tmm tmm mentioned this pull request May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants