fix: do not reconnect on intentional socket close#4601
Merged
Conversation
🦋 Changeset detectedLatest commit: e04dd9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@o19k is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
Also clarifies the changeset wording — the previous wording read as the opposite of the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calling
socketClient.close()triggers the underlyingsocket.close(), which fires theonClosecallback, which callsattemptReconnect(). This causes the socket to reconnect even when the caller explicitly wanted to close it — resulting in the node process never exiting.Root cause:
attemptReconnect()had no way to distinguish between an intentional close and an unexpected socket drop.Fix: Added an
intentionallyClosedflag (closure-scoped, mirrors the existingreconnectInProgresspattern). Set totrueinsocketClient.close()before callingsocket.close(). Checked inattemptReconnect()to skip reconnection.Fixes #4378
Test plan
reconnect on socket-level close— verifies unexpected socket drops still trigger reconnectdoes not reconnect on intentional close— verifiessocketClient.close()no longer reconnectsclose does not reconnect(webSocket integration test) — end-to-end with a real WebSocket