fix: preserve tempo transaction type in prepareTransactionRequest#4612
Merged
Conversation
|
@deodad is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 5987641 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
deodad
force-pushed
the
dad/preserve-tempo-transaction-type
branch
from
0d92ee2 to
5987641
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves the literal Tempo transaction type in prepareTransactionRequest return types.
Motivation
prepareTransactionRequest narrowed built-in transaction types, but fell back to the broad chain request union for type: 'tempo'.
Changes
Testing
pnpm exec biome check src/actions/wallet/prepareTransactionRequest.ts src/tempo/chainConfig.test-d.ts
pnpm exec tsc -b test/tsconfig.json
TYPES=true pnpm exec vitest -c ./test/vitest.config.ts --project type-bench src/tempo/chainConfig.bench-d.ts