fix(encodeEventTopics): do not prepend signature topic for anonymous events#4613
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 5082ead The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@Kropiunig is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
…events Make `EncodeEventTopicsReturnType` conditional on whether the resolved event is anonymous. Non-anonymous events keep the strict `[Hex, ...(Hex | Hex[] | null)[]]` tuple shape (preserving destructuring ergonomics), while anonymous events return `(Hex | Hex[] | null)[]`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR solving?
encodeEventTopicsalways prepended the event selector as the first topic, even for anonymous events. Anonymous events are not identified by a signature topic, so the encoded topics were incorrect and could not be used to filter logs.This adds an
anonymouscheck: for anonymous events the indexed-argument topics are returned as-is, without the leading signature topic. Non-anonymous events are unchanged.Closes #4461
What's changed
src/utils/abi/encodeEventTopics.ts: skip prepending the event selector whenabiItem.anonymousis true. The selector is now only computed for non-anonymous events.EncodeEventTopicsReturnTypewidened from[Hex, ...(Hex | Hex[] | null)[]]to(Hex | Hex[] | null)[], since anonymous events can produce a signature-less (and possibly empty) topic list. This is a superset of the previous type; no internal callers rely on the tuple shape.What alternatives were explored?
Keeping the strict tuple return type and only changing runtime behavior. This was rejected because the tuple type makes a valid (signature-less) anonymous-event result fail typechecking.
What should reviewers pay attention to?
decodeEventLogalready models the signature-less case with| [], so this aligns the encode side.Tests
Added
src/utils/abi/encodeEventTopics.test.ts > https://github.com/wevm/viem/issues/4461covering anonymous events with: no args, a leading indexed arg, all indexed args, and unnamed args.