fix(chains): build explorer api requests with URL params#4625
Merged
Conversation
Replaces fragile template-string concatenation in the `blockExplorer.apiUrl` test path with `new URL()` + `searchParams`, which encodes values safely and preserves pre-existing query params (e.g. Etherscan v2's `chainid=...`). Also normalizes `morphHolesky.apiUrl` to drop the trailing `?`.
🦋 Changeset detectedLatest commit: 25274c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/scripts/chains.test.ts(blockExplorer.apiUrlpath) withnew URL()+searchParams.set(), so values are encoded safely and pre-existing query params (e.g. Etherscan v2chainid=...) are preserved.?frommorphHolesky.apiUrlso the URL is well-formed.patchchangeset for themorphHoleskyfix.Based on #4602 by @tn0vak — credit to them for the diagnosis and original patch.
Test plan
pnpm test:chainspasses against the updatedblockExplorer.apiUrlpath.?.