fix: clear observe caches after unwatch#4630
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 9a6e2c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears
observelistener and cleanup cache entries once the final listener unsubscribes. This prevents short-lived watchers from retaining empty listener arrays and stale cleanup closures afterwatchBlockNumberor similar observers are torn down.Adds regression coverage for final unwatch cache deletion and for a later observer not reusing the previous cleanup. Validated with
SKIP_GLOBAL_SETUP=true pnpm test src/utils/observe.test.tsandpnpm exec biome check src/utils/observe.ts src/utils/observe.test.ts.Closes #4390