refactor(connectors): upgrade @metamask/connect-evm#5070
Merged
Conversation
🦋 Changeset detectedLatest commit: 86dddd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
wenfix
changed the title
wenfix
force-pushed
the
connectors/metamask-connect-return-types
branch
from
b087cb4 to
d937b62
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@wagmi/cli
@wagmi/connectors
@wagmi/core
create-wagmi
wagmi
@wagmi/solid
@wagmi/vue
commit: |
Contributor
|
Size Change: 0 B Total Size: 1.18 MB ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5070 +/- ##
==========================================
+ Coverage 88.89% 88.94% +0.04%
==========================================
Files 296 296
Lines 2747 2749 +2
Branches 797 797
==========================================
+ Hits 2442 2445 +3
+ Misses 113 112 -1
Partials 192 192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jiexi
reviewed
Apr 22, 2026
Comment on lines
+118
to
+124
| signature: signResponse, | ||
| }) | ||
| else if (connectWithResponse) | ||
| provider.emit('connectWith', { | ||
| accounts, | ||
| chainId: numberToHex(currentChainId), | ||
| connectWithResponse, | ||
| result: connectWithResponse, |
Collaborator
There was a problem hiding this comment.
this technically doesn't have to be breaking at the Wagmi connector API if we keep the original event property names intact
Collaborator
There was a problem hiding this comment.
Good point. I suppose there's not a real need to be breaking here on the WAGMI layer
I would support preserving the original event property names
wenfix
changed the title
tmm
reviewed
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@metamask/connect-evmto1.0.0(catalog +@wagmi/connectorspeer range).connectAndSign()now resolves to{ accounts, chainId, signature }(was a raw signature string).connectWith()now resolves to{ accounts, chainId, result }(was a raw result)..signature/.resultbefore emitting.connectAndSignandconnectWithprovider event payloads continue to expose the originalsignResponseandconnectWithResponsekeys — no breaking change for subscribers.Test plan
pnpm --filter @wagmi/connectors check:typespnpm vitest run --project connectors(7/7 passing)@metamask/connect-evm@1.0.0(connect, connectAndSign, connectWith, disconnect, chain switch)