feat: resolve account via getConnectorClient in prepareTransactionRequest#5084
Merged
Merged
Conversation
|
@jxom is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: abad939 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@wagmi/cli
@wagmi/connectors
@wagmi/core
create-wagmi
wagmi
@wagmi/solid
@wagmi/vue
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepareTransactionRequestnow resolves the account viagetConnectorClientwhen noaccountis provided. This lets connectors that implementgetClient(e.g.webAuthn) supply a local signing account instead of falling back to a json-rpc account derived from the connection's address.Also updated the
webAuthnconnector'sgetClientto return a signable account viaprovider.getAccount({ signable: true }).Why
Previously
prepareTransactionRequestusedgetConnection(config).addressfor the account, which gave a plain address. When the underlying viem action needed a local Account (e.g. for tempofeePayer/keyAuthorizationflows), the call chain ended up with a json-rpc account, breaking signing flows that depend on the connector's local account.Changes
packages/core/src/actions/prepareTransactionRequest.ts: resolve account viagetConnectorClient(config, { assertChainId: false, chainId, account })when none is supplied.packages/core/src/tempo/Connectors.ts:webAuthnconnectorgetClientnow passes{ signable: true }toprovider.getAccountso the returned client carries a signable Account.