My opinions: stop following and ignore feature + refactoring#138
Merged
pertrai1 merged 1 commit intowevote:developfrom Mar 17, 2016
lisamburns:my_opinions
Merged
My opinions: stop following and ignore feature + refactoring#138pertrai1 merged 1 commit intowevote:developfrom lisamburns:my_opinions
pertrai1 merged 1 commit intowevote:developfrom
lisamburns:my_opinions
Conversation
…tored voterguidestore
Member
|
👍 Your changes look good to me, but @nf071590 or @pertrai1 should probably weigh in before it is approved. Great work Lisa! |
| }; | ||
|
|
||
| export default GuideActions; | ||
| var Dispatcher = require("../dispatcher/Dispatcher"); |
Member
There was a problem hiding this comment.
preference would be to import and export. If there is a reason not for doing so, I would say to use let
Member
|
✅ |
pertrai1
added a commit
that referenced
this pull request
Mar 17, 2016
My opinions: stop following and ignore feature + refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Made the My Opinions follow/ignore buttons work to remove items per page (consistent with the More Opinions page).
-Refactored GuideStore that the Opinions/MyOpinions page both use to the new style.
-Resolves setState warnings bug on MyOpinions
-Deleted some now deprecated files.
@DaleMcGrew @nf071590