UI Fixes for Negative Feedback Bypass #4682
Merged
+94
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue WV-2510 stops me from making a iOS release, I'll get to it if I have time before my vacation. Non-anonymous emails now have id_string (header) Standard buttons added to ReviewAppModal.jsx Cancel of ReviewAppModal works Default to checked in ReviewAppModal if we have an email address Replaced old isMobile (that relied on user agent detection, which only works sometimes) with isMobileScreenSize() Fixes https://wevoteusa.atlassian.net/browse/WV-2473
Non-anonymous emails now have id_string (header) Standard buttons added to ReviewAppModal.jsx Cancel of ReviewAppModal works Default to checked in ReviewAppModal if we have an email address Replaced old isMobile (that relied on user agent detection, which only works sometimes) with isMobileScreenSize() Fixes https://wevoteusa.atlassian.net/browse/WV-2473
Member
|
Thank you @SailingSteve! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-anonymous emails now have an id_string (header)
Standard buttons have been added to ReviewAppModal.jsx
Cancel of ReviewAppModal works
We now default to "checked" in ReviewAppModal if we have an email address.
Replaced old isMobile (that relied on user agent detection, which only works sometimes) with isMobileScreenSize()
Fixes https://wevoteusa.atlassian.net/browse/WV-2473