Clean up Tracking subtabs: shared styles file, alphabetize, fix lint warnings#4819
Merged
Merged
Conversation
…warnings - Move the shared Tracking styled-components into their own file (Style/SupporterTrackingStyles.jsx) so they don't pollute Style/ManageMyCandidates or SupporterTracking. - Add a small TrackingHeaderActionContext file so the three subtabs can share the header-action slot without a circular import. - Alphabetize the styled-components in all the Tracking files and the shared style files, just to keep things easy to find. - Add PropTypes to ActionPill, the Menus exports, SupportersJoined/Invited/ToRemind, and CardOpinionRow. Also move getPendingActions/getActionsLabel out of SupportersJoined so the useMemo hook stops complaining about missing deps.
ric0de
force-pushed
the
WV-4237MergeJoinedInvited
branch
from
51c32ef to
0c6e6e1
Compare
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the shared Tracking styled-components into their own file (Style/SupporterTrackingStyles.jsx) so they don't pollute Style/ManageMyCandidates or SupporterTracking.
Add a small TrackingHeaderActionContext file so the three subtabs can share the header-action slot without a circular import.
Alphabetize the styled-components in all the Tracking files and the shared style files, just to keep things easy to find.
Add PropTypes to ActionPill, the Menus exports, SupportersJoined/Invited/ToRemind, and CardOpinionRow. Also move getPendingActions/getActionsLabel out of SupportersJoined so the useMemo hook stops complaining about missing deps.