[WV-4547] Election Finder UI iter #2#4821
Merged
Merged
Conversation
- ElectionFinderHeader: state label now renders after the breadcrumbs (was above the h1) so the layout reads Election Finder -> breadcrumb -> STATE -> election title -> date - ElectionFinderForElection: - 3-crumb breadcrumb (Election Finder Home / Upcoming|Past Elections - State (N) / Election Name - Date (officeCount)) - Election title now shows office count e.g. "State Primary (2)" - Date rendered below the title via new ElectionDetailDate styled component (matches the state label color so they bracket the title) - Empty-state copy split: "No results found." remains for search-no-match; new "Our team hasn't assembled the data for this election yet..." copy when the election has zero offices and no active search - Slightly larger ElectionFinderStateLabel scoped to the Finder so Ballot pages keep the original size - Extract formatDateLong to new dateHelpers.js; refactor ElectionFinderHome + ElectionFinderForState to import it (drops two duplicate copies)
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
← Election Finder Home / Upcoming|Past Elections - State (N) / Election Name - Date (officeCount).State Primary (2).ElectionDetailDatestyled component (matches state label color so the two frame the title in the same hue).No results found.is preserved for search-no-match; a newOur team hasn't assembled the data for this election yet. We usually have election data 45 days before each election.message appears when the election has zero offices and no active search.ElectionStateLabel) so Ballot pages keep the original size.formatDateLonginto newdateHelpers.js; refactoredElectionFinderHomeandElectionFinderForStateto import it (drops two duplicate copies).**Depends on: (
[WV-2660]Election Finder iter 1). I'll rebase this branch once that lands so the diff collapses to a single commit.