Allow configuring max retries #83
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed typo in README.md
…ed tests to run with multiple workers
the test now validates that messages get rejected when handlers return an error and all rety attempts did not sccueed
increased test coverage
added tests for protobuf serlializer
…ga was created. This fixes #74
fixing a bug where saga configuration functions were run only when saga was created
fix wrong timeout interface method in documentation
increasing test timeouts of ci build to 60s
Timeouts now are not passed as bus messages to avoid the need to deal with serialization. Timeout interface changed so that handling a timeout now accepts a transaction and a bus instance instead of an invocation and a bus message
This allows saga instances ifthey choose to continue react to messages after they timeout
otherwise updating it In addition fixing some linting errors
first commit towards supporting persistent timeouts
update documentation after changes of timeout interface : https://github.com/wework/grabbit/pull/78/files
Update SAGA.md - timeout interface doc fix
transaction When a handler fails and gets retried each retry should be run in a new transaction
fixing a bug in which all handler retires executed within the same
Contributor
|
@avigailberger I am closing this PR. please create a new one that merges from your branch into the v1.x branch and not to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retries
Provide a way to externally configure the maximum amount of retries handlers get executed before declaring the message as poison and rejecting it
Closes #35