Linter show more than one rule#11
Merged
philsturgeon merged 2 commits intowework:masterfrom Feb 26, 2018
jblazek:feat/6-show-multiple-results
Merged
Linter show more than one rule#11philsturgeon merged 2 commits intowework:masterfrom jblazek:feat/6-show-multiple-results
philsturgeon merged 2 commits intowework:masterfrom
jblazek:feat/6-show-multiple-results
Conversation
Enabled output of multiple lint rule validation errors. Previously, only the first error was displayed.
Changed test fixture to check rule names that did not pass linting against and expected set of rule names.
philsturgeon
approved these changes
Feb 26, 2018
Contributor
philsturgeon
left a comment
philsturgeon
left a comment
There was a problem hiding this comment.
You are unstoppable! Doing amazing work, thank you so much. :)
Contributor
|
Excellent, and nicely implemented! |
Contributor
|
Oh |
Merged
Contributor
Author
|
thanks for the feedback! I'll be installing the new version and working on getting it included in CI. |
Contributor
|
We need to take care of another TODO item, which is multiple output formats. We need to putut to something like JUnit so travis, circle, etc are happy showing the specific failures. https://relishapp.com/cucumber/cucumber/docs/formatters/junit-output-formatter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to collect lint errors and return all instead of just the first one.
Stopped the
shouldexceptions from bubbling up, these are collected along with the specific rule that failed and other relevant context info. These results get returned as a new options propertylintResults.Let me know if you wanted anything changed up. The schema validation will still only return the first error, but that could be handled in another issue following a similar pattern.
Fixes #6