Add skip option for linter#9
Merged
philsturgeon merged 2 commits intowework:masterfrom Feb 24, 2018
jblazek:feat/5-skip-rule
Merged
Add skip option for linter#9philsturgeon merged 2 commits intowework:masterfrom jblazek:feat/5-skip-rule
philsturgeon merged 2 commits intowework:masterfrom
jblazek:feat/5-skip-rule
Conversation
Added `--skip` option for linter to skip one or more rules by name from linting. Fixes #5
Contributor
Author
|
I took a shot at this, it would be useful for me as well. Let me know if you had something else in mind. I looked at adding tests, but would either need to make a new profile or change up what's in a fixture to add a skip array there. |
Contributor
|
This is awesome! Thank you so much. Could you have a think about tests, and see what you come up with after another try? Changing how things work is quite alright. |
Contributor
Author
|
Sure I can see about changing it up. |
Added tests to cover skipping specific lint rules. Updated test fixture to allow skipping different rules at the test level.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
--skipoption for linter to skip one or more rules by name fromlinting.
Fixes #5