Conversation
Owner
|
FWIW, this PR seems to break the Windows build |
Owner
|
Thank you! |
Owner
|
I've published updated versions to crates.io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Sorry for the previous PR #23 , as it only partially solves build issue for Android, and is inconsistent across hosts.
This PR instead of defining
__ANDROID_API__, defines_BSD_SOURCEonly for Android to ensure build consistency across different versions. Also, workflow for Android has been added to verify the whole build process on Linux, Windows and macOS.The same patch has been verified working for upstream CMake project as well, so I believe this is the correct patch to get a working build without worrying about target API version.