feat: acronym

[carlocorradini]

Fix #34

[alerque]

First, this is going to find false positives of any single words in parenthesis, e.g.:

this heading is a title (subject)

Secondly, anything along these lines would need to (in my opinion) gated behind an option of some kind.

[carlocorradini]

@alerque Yes, that's why it's a draft. We can start with this and refine 🙌

[carlocorradini]

First, this is going to find false positives of any single words in parenthesis, e.g.:

this heading is a title (subject)

Secondly, anything along these lines would need to (in my opinion) gated behind an option of some kind.

this heading is a title (subject)
is correctly transformed to
This Heading Is a Title (Subject)

To determine whether a word is an acronym, there are two checks:

1. Check if the number of open and closed braces is equal
2. Regex to check if a word between brackets is all uppercase and/or contains numbers: (?x)\A\(+[A-Z0-9]+\)+\z

[wezm]

This seems reasonable from a quick glance.

[carlocorradini]

@wezm @alerque Could you please share your opinions and suggestions? Thanks 🥳☺️

[wezm]

Yep I plan to review properly this weekend.

[wezm]

This looks good to me. Did you have any outstanding concerns @alerque?

[alerque]

Yes. It doesn't seem to be optional yet, and it does still look like it will be easy to trip with false positives.

WHAT ABOUT TITLE CASING THIS (SAMPLE) INPUT?

[wezm]

That seems to produce the same output with the current version and this branch?

   Compiling titlecase v3.4.0 (/home/wmoore/Projects/titlecase)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.23s
 10:07  ~  Projects  titlecase  titlecase <<< 'WHAT ABOUT TITLE CASING THIS (SAMPLE) INPUT?'
What About Title Casing This (Sample) Input?
 10:07  ~  Projects  titlecase  target/debug/titlecase <<< 'WHAT ABOUT TITLE CASING THIS (SAMPLE) INPUT?'
What About Title Casing This (Sample) Input?

[carlocorradini]

@wezm This is because of the following line:

titlecase/src/lib.rs

Lines 113 to 117 in e87fa34

	let trimmed_input = if trimmed_input.chars().any(|ch| ch.is_lowercase()) {
	Cow::from(trimmed_input)
	} else {
	Cow::from(trimmed_input.to_lowercase())
	};

[wezm]

@carlocorradini yes, it seems to working as desired.