Update cpu_work_per_thread calculation to better match cpu-benchmark#152
Merged
henricasanova merged 1 commit intomainfrom May 6, 2026
Merged
Update cpu_work_per_thread calculation to better match cpu-benchmark#152henricasanova merged 1 commit intomainfrom
henricasanova merged 1 commit intomainfrom
Conversation
Signed-off-by: Steven Hahn <hahnse@ornl.gov>
Contributor
|
I concur. The stress-ng code doesn't really batch the calculation. I mean, it's odd. I am not sure why they have this grouping iterations into groups of 16384, but based on the stress-ng code you highlight, the total number of iterations is |
henricasanova
approved these changes
May 6, 2026
Contributor
henricasanova
left a comment
henricasanova
left a comment
There was a problem hiding this comment.
looks reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cpu-benchmark calculated 1000000 points per unit of cpu_work. In contrast, stress-ng's input is in units of 1 point.
I thought stress-ng batched the calculation in units of 16384 points, but that doesn't appear to be the case.
https://github.com/ColinIanKing/stress-ng/blob/c6952a9ececa120975f84f3ca969bd3c258c77ef/stress-monte-carlo.c#L333