fix: used task's id instead of name in abstract recipe generation#78
Merged
rafaelfsilva merged 1 commit intowfcommons:mainfrom Jun 14, 2025
Merged
Conversation
rafaelfsilva
approved these changes
Jun 14, 2025
Member
|
Thank you @ftschirpke for finding this issue and fixing the bug. The PR has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes multiple uses of
.nameto the respective ID (.task_idor.file_idrespectively) in the abstract recipe classes.Problem
I noticed that generating a workflow from a recipe produced tasks do not interact with eachother. Minimal example:
output:
This means that no task has input files that are outputs of a previous task.
Solution
After a bit of debugging, I found that new files are generated for each task because checks in the abstract recipe generation fail to find the files in parent tasks due to inconsistent usage of
task.nameandtask.task_id.output after the changes: