forgit::add no longer shows untracked files

[alaaibrahim]

recently I noticed that forgit::add , is no longer showing untracked files, after investigating, to see what might have caused that, I was able to track the bug to the commit 2c17635d where the issue is with the -z flag

it seems when the -z flag is there, untracked files no longer have the color code on them, thus they would be excluded on the next grep

This is running on git git version 2.50.1 (Apple Git-155)

It seems like a bug with git itself, but also I'm sure other people might have the same experience, if there is a way this could be handled here, as this is the version that comes on macOS Tahoe

I've tested this on linux, git version 2.52.0 and that works as expected, there is no bug

[alaaibrahim]

Just to mention that installing git from homebrew git version 2.53.0 would also fix the issue

[sandr01d]

Thanks for bringing this to our attention @alaaibrahim. I'm wondering whether we should just revert 2c17635 in this case. The bug it fixes (#467) is an edge case and being compatible with the git version that macOS ships is probably more important.

[alaaibrahim]

As I looked at it, I don't think that it's fair to throw this responsibility on this application, where the bug exists in an older version of git I assume this is the solution for it git/git@50927f4 which was released 2.50.2.

I added a pull request to modify the README file in case someone else has this bug they don't have to debug it as I did.

I know it's not my decision, but my suggestion would be not break a use case (although an edge one) just because Mac ships with an older git version, where the user can simply upgrade to resolve.