Implement server-side language validation on exercise description steps#1189
Merged
rolandgeider merged 2 commits intowger-project:masterfrom May 7, 2026
Conversation
Closes wger-project#930. The validateLanguage stub in AddExerciseProvider was making the API call but ignoring the response and always returning false. This wires it up properly: the method now returns null on success or the server's error message on a language mismatch (caught from the 400 WgerHttpException). The stepper's onStepContinue is now async-aware for steps 2 (Description) and 3 (Translation) — it calls validateLanguage after form validation passes, blocks navigation, and displays the error inline if the check fails. Mocks regenerated to reflect the return type change from Future<bool> to Future<String?>.
umaidshahid
force-pushed
the
feature/930-validate-language-on-step-continue
branch
from
03beee2 to
f62c6b2
Compare
Member
|
merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
validateLanguagestub inAddExerciseProviderwas making the API call but ignoring the response and always returning false. This wires it up properly: the method now returnsnullon success or the server's error message on a language mismatch (caught from the 400WgerHttpException). The stepper'sonStepContinueis now async-aware for steps 2 (Description) and 3 (Translation) — it callsvalidateLanguageafter form validation passes, blocks navigation, and displays the error inline if the check fails. Mocks regenerated to reflect the return type change fromFuture<bool>toFuture<String?>.Proposed Changes
validateLanguagestub to parse the API response and return the server's error message on language mismatchFuture<bool>→Future<String?>return type changeRelated Issue(s)
closes #930
Please check that the PR fulfills these requirements
dart format .)