Fix/exercise UI match ingredients#1235
Fix/exercise UI match ingredients#1235Sahasra0108 wants to merge 4 commits intowger-project:masterfrom
Conversation
…Icon filter popup, language dropdown, and localStorage support
| const [t, i18n] = useTranslation(); | ||
| const [inputValue, setInputValue] = React.useState(""); | ||
| const [searchEnglish, setSearchEnglish] = useState<boolean>(true); | ||
| const defaultLanguageFilter = i18n.language === LANGUAGE_SHORT_ENGLISH |
There was a problem hiding this comment.
since this is basically the same as the IngredientLanguageFilter, I would suggest renaming that to something like SearchLanguageFilter, putting it somewhere in core and using it both in the ingredient and this search
| * Search for exercises by name using the exerciseinfo endpoint | ||
| */ | ||
| export const searchExerciseTranslations = async (name: string, languageCode: string = ENGLISH_LANGUAGE_CODE, searchEnglish: boolean = true): Promise<Exercise[]> => { | ||
| export const searchExerciseTranslations = async (name: string, languageCode: string = ENGLISH_LANGUAGE_CODE, searchEnglish: boolean = true, exactMatch: boolean = false): Promise<Exercise[]> => { |
There was a problem hiding this comment.
we should pass the language filter like in searchIngredient(I'm just trying to make both look and work as similarly as possible)
|
|
||
| const adapter = new ExerciseAdapter(); | ||
| return data.results.map((item: unknown) => adapter.fromJson(item)); | ||
| const exercises = data.results.map((item: unknown) => adapter.fromJson(item)); |
There was a problem hiding this comment.
sorry, the issue probably wasn't clear. If the exact match flag is set, we filter by name with name, otherwise with name__search like before. We should not do any matching client side
|
coverage: 75.45% (-0.09%) from 75.54% — Sahasra0108:fix/exercise-ui-match-ingredients into wger-project:master |
3 participants
Proposed Changes
vs fulltext search (name__search=foo)
Related Issue(s)
Related to wger-project/wger#2279 (implements React part of exercise search UI improvements)
Screenshots
1. Filter popup with Language dropdown and Exact match toggle
2. Fuzzy search (Exact match OFF) - shows multiple results
3. Exact match ON - shows only exact result
4. Filter panel hidden - grid expands to full width
5. Filter panel visible
Please check that the PR fulfills these requirements